Fix extension not starting in vscode < 1.55 #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbricon
added
bug
Update vscode-redhat-telenetry to 0.2.0, to fix ``` Activating extension 'redhat.vscode-xml' failed: Cannot read property 'id' of undefined. ``` Signed-off-by: Fred Bricon <fbricon@gmail.com>
fbricon
force-pushed
the
update-telemetry
branch
from
5b03c35
to
262495b
Compare
|
vscode-xml won't run in Theia anyways, since this release requires the language client version 7, which requires being compatible with the 1.52 API. However, it would be nice to support VS Code 1.52+ and Theia once it's compatible with the new language client version. |
datho7561
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update vscode-redhat-telenetry to 0.2.0, to fix
This affects vscode API < 1.55 (Che/Theia are at 1.50)