Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support shouldLanguageServerExitOnShutdown capability #530

Merged

Conversation

datho7561
Copy link
Contributor

@datho7561 datho7561 commented Jun 25, 2021

Supports the capability, which means that language server shuts down when shutdown is received instead of when exit is received.

See eclipse/lemminx#1070

Signed-off-by: David Thompson davthomp@redhat.com

@datho7561
Copy link
Contributor Author

Need to change package.json to lemminx 0.17.1

Supports the capability, which means that language server shuts down
when `shutdown` is received instead of when `exit` is received.

See eclipse/lemminx#1070

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 marked this pull request as ready for review June 25, 2021 16:11
@datho7561 datho7561 requested a review from rgrunber June 25, 2021 17:22
Copy link
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@datho7561 datho7561 added this to the 0.17.0 milestone Jun 25, 2021
@datho7561 datho7561 merged commit 4912bfa into redhat-developer:master Jun 25, 2021
@datho7561 datho7561 deleted the support-exit-on-shutdown branch June 25, 2021 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants