Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report only XML syntax error for *.exsd files #782

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

angelozerr
Copy link
Contributor

Report only XML syntax error for *.exsd files

Signed-off-by: azerr azerr@redhat.com

@datho7561
Copy link
Contributor

datho7561 commented Oct 11, 2022

I think that this setting needs some documentation, especially since it doesn't ignore errors coming from <?xml-model processing instructions yet

@angelozerr
Copy link
Contributor Author

I think that this setting needs some documentation, especially since it doesn't ignore errors coming from <?xml-model processing instructions yet

It is a bug,so we should create an issue on LemMinx side

@datho7561
Copy link
Contributor

I opened eclipse/lemminx#1312, but we should document the behaviour of the setting

@angelozerr
Copy link
Contributor Author

I opened eclipse/lemminx#1312, but we should document the behaviour of the setting

Thanks!

@datho7561 datho7561 assigned datho7561 and unassigned datho7561 Oct 13, 2022
@datho7561 datho7561 self-requested a review October 13, 2022 16:36
@datho7561
Copy link
Contributor

@angelozerr do you think you could add some documentation for this setting in the PR?

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr
Copy link
Contributor Author

@angelozerr do you think you could add some documentation for this setting in the PR?

Sorry to do that in late, fixed.

Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks, Angelo!

@datho7561 datho7561 added this to the 0.22.0 milestone Oct 18, 2022
@datho7561 datho7561 added the enhancement New feature or request label Oct 18, 2022
@datho7561 datho7561 merged commit 29457ac into redhat-developer:main Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants