Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation and settings for experimental formatter to default #823

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Update documentation and settings for experimental formatter to default #823

merged 1 commit into from
Dec 5, 2022

Conversation

JessicaJHee
Copy link
Contributor

@JessicaJHee JessicaJHee commented Nov 24, 2022 •
edited

  • removes xml.format.experimental settings
  • introduces new xml.format.legacy to revert to old formatter

Fixes eclipse/lemminx#1377
Requires eclipse/lemminx#1381

Signed-off-by: Jessica He jhe@redhat.com

@JessicaJHee JessicaJHee marked this pull request as ready for review November 28, 2022 18:23
datho7561
datho7561 requested changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! I just noticed some wording that I think could be improved, let me know what you think. Everything else looks good.

docs/Formatting.md Outdated Show resolved Hide resolved
docs/Formatting.md Outdated Show resolved Hide resolved
@datho7561
Copy link
Contributor

Looks good, just want to make sure it works with the lemminx change. I'll check that first thing tomorrow.

@datho7561 datho7561 self-requested a review December 5, 2022 14:14
@datho7561 datho7561 added enhancement New feature or request formatting labels Dec 5, 2022
@datho7561 datho7561 merged commit 6bcda21 into redhat-developer:main Dec 5, 2022
@JessicaJHee JessicaJHee deleted the udpate-exp-doc branch December 5, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datho7561 datho7561 datho7561 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request formatting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch experimental formatter to default
2 participants
@JessicaJHee @datho7561