Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple support for xml.references" #855

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

angelozerr
Copy link
Contributor

multiple support for xml.references"

Signed-off-by: azerr azerr@redhat.com

Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. I think the wording of the settings that apply to multiple expressions could be improved

docs/Features/XMLReferencesFeatures.md Outdated Show resolved Hide resolved
docs/Features/XMLReferencesFeatures.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Signed-off-by: azerr <azerr@redhat.com>
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks, Angelo!

@datho7561 datho7561 added the enhancement New feature or request label Jan 13, 2023
@datho7561 datho7561 added this to the 0.24.0 milestone Jan 13, 2023
@datho7561 datho7561 merged commit c7ed01d into redhat-developer:main Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants