Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider providing a 'yamlValidation' contribution point for registering a schema #37

Closed
egamma opened this issue Oct 5, 2017 · 5 comments

Comments

@egamma
Copy link

egamma commented Oct 5, 2017

Such a contribution point enables an extension author to contribute a YAML schema association same as is done for JSON and its jsonValidation contribution point.

https://code.visualstudio.com/docs/extensionAPI/extension-points#_contributesjsonvalidation

The corresponding code in the JSON extension for this can be found here:
https://github.com/Microsoft/vscode/blob/master/extensions/json/client/src/jsonMain.ts#L174

@JPinkney
Copy link
Contributor

JPinkney commented Oct 5, 2017

Added in 9fdaa7f!

@JPinkney JPinkney closed this as completed Oct 5, 2017
@egamma
Copy link
Author

egamma commented Oct 5, 2017

nice!

@gorkem
Copy link
Collaborator

gorkem commented Oct 6, 2017

@JPinkney can you also add some documentation for it ?

@JPinkney
Copy link
Contributor

JPinkney commented Oct 6, 2017

@gorkem Yes, i'll do that now

apupier pushed a commit to apupier/vscode-yaml that referenced this issue Jul 2, 2020
bleach31 pushed a commit to bleach31/vscode-yaml that referenced this issue Jan 25, 2022
bleach31 pushed a commit to bleach31/vscode-yaml that referenced this issue Jan 25, 2022
fix issue redhat-developer#37 completionHelper will break yaml file if it contains \r …
@starball5
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants