Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode/jsonschema markdownDescription support seems patchy #417

Closed
1 of 4 tasks
phlax opened this issue Jan 18, 2021 · 1 comment · Fixed by redhat-developer/yaml-language-server#431
Closed
1 of 4 tasks
Assignees
Labels
Milestone

Comments

@phlax
Copy link

phlax commented Jan 18, 2021

Describe the bug

not entirely clear if this is the correct place to post this issue - but ill start here 8/

vscode has support for a custom jsonschema field markdownDescription

when i add a markdownDescription field in my custom schema, it works only for hovering not for autocomplete

checking the kubernetes extension and i see something similar - unformatted links when using autocomplete, but correct links when i hover over the value

Expected Behavior

markdownDescripton should work for both autocomplete and hover

Current Behavior

markdownDescripton only works for hover

Steps to Reproduce

  1. add a kubernetes yaml file
  2. add metadata, and then add name
  3. check the autocomplete on name - link in description should be unformatted
  4. add name
  5. hover, and link in field description should work correctly

Environment

  • Windows
  • Mac
  • Linux
  • other (please specify)
@JPinkney
Copy link
Contributor

My guess is that we haven't fully ported over markdownDescription for autocompletion from https://github.com/microsoft/vscode-json-languageservice/blob/master/src/services/jsonCompletion.ts yet

@JPinkney JPinkney added the bug label Jan 30, 2021
@evidolob evidolob added this to the 0.17.0 milestone Mar 3, 2021
@evidolob evidolob modified the milestones: 0.17.0, 0.18.0 Mar 24, 2021
@evidolob evidolob self-assigned this Mar 25, 2021
bleach31 pushed a commit to bleach31/vscode-yaml that referenced this issue Jan 25, 2022
* redhat-developer#354 Fix 'fileMatch' pattern to match whole file name

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

* add test

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
bleach31 pushed a commit to bleach31/vscode-yaml that referenced this issue Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants