Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily revert the Telemetry feature #515

Closed
fbricon opened this issue May 20, 2021 · 4 comments
Closed

Temporarily revert the Telemetry feature #515

fbricon opened this issue May 20, 2021 · 4 comments
Assignees
@evidolob

Comments

@fbricon
Copy link
Contributor

fbricon commented May 20, 2021

Is your enhancement related to a problem? Please describe.

The vscode-commons dependency irks some users.

Describe the solution you would like

Before the latest release is fully rolled out, we should revert the change ASAP and try to find an alternative to the currently correct technical solution.

Describe alternatives you have considered

Simply removing the vscode-commons dependency might cause some runtime errors, it seems safer to rollback telemetry as a whole for now.
@evidolob evidolob self-assigned this May 21, 2021
@evidolob
Copy link
Collaborator

I can remove dependency, and make sure that vscode-yaml will work without vscode-commons.

evidolob added a commit to evidolob/vscode-yaml that referenced this issue May 21, 2021
@evidolob
redhat-developer#515 remove telemetry
c0df53a 
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
@evidolob evidolob mentioned this issue May 21, 2021
Merged
evidolob added a commit that referenced this issue May 21, 2021
@evidolob
Remove telemetry (#516)
34389de 
* #515 remove telemetry

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

* update readme, remove installation of commons ext

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
@fbricon
Copy link
Contributor Author

fbricon commented May 21, 2021

Telemetry will be back!

@spirillen
Copy link

SpyWare, uninstalled...

@fbricon
Copy link
Contributor Author

fbricon commented Jun 1, 2021

@spirillen VS Code implements telemetry collection by default, you have to explicitly opt-out.
On the other hand, Red Hat extensions implement telemetry collection as an anonymous (as in no personally identifiable data, not even IP address is collected), opt-in process, so no data is collected until you explicitly agree.

And vscode-yaml is currently not implementing telemetry collection.

@fbricon fbricon mentioned this issue Jun 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evidolob evidolob

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fbricon @evidolob @spirillen