Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for anchors/references? #60

Closed
rylnd opened this issue Jan 31, 2018 · 3 comments
Closed

Support for anchors/references? #60

rylnd opened this issue Jan 31, 2018 · 3 comments
Assignees
Labels

Comments

@rylnd
Copy link

rylnd commented Jan 31, 2018

Hi! First, thanks for the great plugin.

I'm having an issue with validations not respecting injected references. For example, in a Circle CI 2.0 config file, I've got the docker key in a reference:

defaults: &job_defaults
  docker:
    - image: circleci/node:8.2.1

and then use it later in a job:

jobs:
  job1: 
    <<: *job_defaults

However, I still receive a Missing property "docker". message on the job1 node.

Is this the expected behavior? Thanks in advance.

@JPinkney JPinkney self-assigned this Jan 31, 2018
@JPinkney JPinkney added the bug label Jan 31, 2018
@JPinkney
Copy link
Contributor

JPinkney commented Feb 1, 2018

I'm still working on this issue but I've done a bit of investigation, it looks like the yaml parser is getting back the correct results, so it looks to be something either schema or json parser side.

@rylnd
Copy link
Author

rylnd commented Feb 1, 2018

@JPinkney thanks for the fix! I look forward to its release!

@ssbarnea
Copy link
Member

Clearly this bug needs to be reopen because current version does not work with them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants