Start extension on 'dockercompose' language mode #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
|
Looking at https://github.com/microsoft/vscode/blob/c2347df53bc9b02b1681b12cee892ecaccfbe789/extensions/yaml/package.json#L17-L29, I'd say this change looks safe |
JPinkney
approved these changes
Nov 23, 2021
|
Could this be the reason for #1000? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
For some reason VSCode provide own language mode for docker compose files - https://github.com/microsoft/vscode/blob/main/extensions/yaml/package.json#L17
This PR add activation event for
dockercomposelanguage mode and bind yaml-ls to it.What issues does this PR fix or reference?
none
Is it tested? How?
manually