Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenShift Toolkit extension recommendation #892

Merged
merged 5 commits into from
Mar 2, 2023

Conversation

msivasubramaniaan
Copy link
Contributor

What does this PR do?

This PR recommends OpenSift Toolkit extension when the workspace folder contains 'devfile.yaml'

What issues does this PR fix or reference?

redhat-developer/vscode-openshift-tools#2592

Is it tested? How?

Yes with UT

…kspace has devfile.yaml

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Copy link
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks pretty good. Just some minor things to fix, and then I think we can merge.

src/extension.ts Outdated Show resolved Hide resolved
src/recommendation/dependencyAnalytics.ts Outdated Show resolved Hide resolved
src/recommendation/dependencyAnalytics.ts Outdated Show resolved Hide resolved
src/recommendation/dependencyAnalytics.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
msivasubramaniaan and others added 4 commits March 2, 2023 13:29
Co-authored-by: Roland Grunberg <rgrunber@redhat.com>
Co-authored-by: Roland Grunberg <rgrunber@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Copy link
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Feel free to squash and merge when ready.

@msivasubramaniaan msivasubramaniaan merged commit d440c01 into main Mar 2, 2023
@msivasubramaniaan msivasubramaniaan deleted the show-openShift-toolkit-recommendation branch March 2, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants