Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid providing completion when "maxProperties" is reached #269

Closed
apupier opened this issue Jul 3, 2020 · 2 comments
Closed

Avoid providing completion when "maxProperties" is reached #269

apupier opened this issue Jul 3, 2020 · 2 comments
Milestone
0.9.0

Comments

@apupier
Copy link
Member

apupier commented Jul 3, 2020 •
edited
Loading

it is possible to specify "maxProperties". So for instance I have a value set to 2, and I can have tag property in [tag1, tag2, tag3] if I have:

- tag1:
  tag2:

And that I call completion on last line, there should be no completion.

nota: Issue detected while working on Apache Camel K schema https://gist.github.com/lburgazzoli/70027ee39196c18008e1a455ef02566c
apupier added a commit to apupier/yaml-language-server that referenced this issue Jul 3, 2020
@apupier
Provide test on expected behavior for maxProperties redhat-developer#269
b2729c0 


Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier
Copy link
Member Author

apupier commented Jul 3, 2020

provided a PR with tests to show expected behavior #270

apupier added a commit to apupier/yaml-language-server that referenced this issue Jul 3, 2020
@apupier
Implement the respect of maxProperties for arrays ( fixes redhat-deve…
cf8f438 
…loper#269 )

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier
Copy link
Member Author

apupier commented Jul 6, 2020

Pr updated with an implementation respecting the maxProperties value

JPinkney added a commit that referenced this issue Jul 6, 2020
@JPinkney
Merge pull request #270 from apupier/269-respectMaxpropertiesForCompl…
292c956 
…etion

Avoid providing completion when "maxProperties" is reached #269
@apupier apupier added this to the 0.9.0 milestone Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

No branches or pull requests
1 participant
@apupier