Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete should not escape colon without white-space following #571

Closed
donorp opened this issue Oct 30, 2021 · 1 comment
Closed

Autocomplete should not escape colon without white-space following #571

donorp opened this issue Oct 30, 2021 · 1 comment
Milestone

Comments

@donorp
Copy link
Contributor

donorp commented Oct 30, 2021

Is your enhancement related to a problem? Please describe.

Introduced in #475 as the fix of #474 : property name with colon gets escaped.

But when the key is in part-a:part-b or :part-b format, there is no white-sapce following the colon, the colon is not indicating a map, we should not escape the key, as that's just plain yaml string.

Describe the solution you would like

Do not escape keys in part-a:part-b or :part-b format.

Describe alternatives you have considered

None.

Additional context

Further more, yaml accepts arbitrary map key, the key can be a map or an array:

{k1: v1, k2: v2}: v3
[v1, v2]: v3

probably that should not be considered for now.

@evidolob evidolob added this to the 1.2.0 milestone Nov 2, 2021
evidolob pushed a commit that referenced this issue Nov 2, 2021
Should only escape keys when the colon inside is indicating a map

#571

Signed-off-by: donorp <donorp@arhat.solutions>
@evidolob
Copy link
Collaborator

evidolob commented Nov 2, 2021

Resolved with #572

@evidolob evidolob closed this as completed Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants