Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use textDocument.formatting.dynamicRegistration? #74

Closed
iquiw opened this issue Jun 12, 2018 · 3 comments
Closed

Use textDocument.formatting.dynamicRegistration? #74

iquiw opened this issue Jun 12, 2018 · 3 comments

Comments

@iquiw
Copy link
Contributor

iquiw commented Jun 12, 2018

yaml-language-server currently uses workspace.symbol.dynamicRegistration to determine whether it registers textDocument/formatting capability.

According to the language-server-protocol spec, textDocument.formatting.dynamicRegistration looks appropriate for the purpose.

/**
 * Text document specific client capabilities.
 */
export interface TextDocumentClientCapabilities {
...
	/**
	 * Capabilities specific to the `textDocument/formatting`
	 */
	formatting?: {
		/**
		 * Whether formatting supports dynamic registration.
		 */
		dynamicRegistration?: boolean;
	};
@JPinkney
Copy link
Contributor

Yes that should be changed. Is that something you'd like to contribute?

@iquiw
Copy link
Contributor Author

iquiw commented Jun 22, 2018

I sent PR. As far as checked, formatting works as previous on VSCode.

@JPinkney
Copy link
Contributor

Awesome thanks! I'll merge it!

iquiw added a commit to iquiw/lsp-yaml that referenced this issue Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants