Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix document symbols computation if yaml has complex mappings #293

Merged

Conversation

evidolob
Copy link
Collaborator

@evidolob evidolob commented Aug 4, 2020

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
@evidolob evidolob requested a review from JPinkney August 4, 2020 12:34
@evidolob evidolob self-assigned this Aug 4, 2020
Copy link
Contributor

@JPinkney JPinkney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work! Can you add a test and then I'll merge

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
test/documentSymbols.test.ts Outdated Show resolved Hide resolved
test/documentSymbols.test.ts Outdated Show resolved Hide resolved
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
@JPinkney JPinkney merged commit 82b398f into redhat-developer:master Aug 6, 2020
@evidolob evidolob deleted the fix-symbols-for-complex-mapping branch August 6, 2020 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request textDocument/documentSymbol failed when using complex mapping with alias
2 participants