Add support of Yaml Schema #318
Conversation
This adds support to the loadSchema function to attempt loading of a schema file containing YAML formatted schemata. Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
…rver into yaml-scheme
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
| } | ||
|
|
||
| try { | ||
| const schemaContent: JSONSchema = yaml.safeLoad(content); |
There was a problem hiding this comment.
If you are doing a simple conversion then I'm concerned that it might not work with k8s yaml schemas. The structure of which has the schema held within it.
There was a problem hiding this comment.
@joshuawilson I'm not sure that understand your point, can you add sample of such k8s yaml scheme?
There was a problem hiding this comment.
Here is a link to the Knative Eventing Subscription schema. Notice that is has structure wrapping the actual schema.
https://github.com/knative/eventing/blob/master/config/core/resources/subscription.yaml
The schema needed for validation doesn't start until line 32. If we include the rest, will validation actually work?
There was a problem hiding this comment.
No, because that file itself is not YAML Scheme, it is k8's CRD. To get actual scheme you need to extract that yaml in to separate yaml file
There was a problem hiding this comment.
This is a fine, I was just hoping to be able to point to the URL for a k8s schema and use it. But I do understand that has become a more generic tool.
This PR based on #191, with resolving merge conflicts and tests.