Fix completion indentation for object in array #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
JPinkney
approved these changes
Oct 7, 2020
joshuawilson
reviewed
Oct 7, 2020
joshuawilson
reviewed
Oct 7, 2020
| @@ -260,7 +260,7 @@ export class YAMLCompletion extends JSONCompletion { | |||
| addValue: boolean, | |||
| separatorAfter: string, | |||
| collector: CompletionsCollector, | |||
| document | |||
| document: TextDocument | |||
There was a problem hiding this comment.
Did you know that TextDocument is deprecated?
There was a problem hiding this comment.
Yes, but we use it across all project.
joshuawilson
reviewed
Oct 7, 2020
| `${indent}${this.indentation}`, | ||
| insertIndex++ | ||
| ); | ||
| const objectInsertResult = this.getInsertTextForObject(schema, separatorAfter, `${this.indentation} `, insertIndex++); |
There was a problem hiding this comment.
Do you need to also make this change for line 736 above?
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
joshuawilson
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is firs PR, fix completion snippet generation for object in array. We also have problem with settings synchronisation, in case if
editor.tabSizeset up in language scope[yaml]we not take in account it. This PR fix that, but it also requires fix invscode-yamlwhich I'm going to provide.For #329