Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow array for fileMatch in yamlValidation contribution #348

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

JPinkney
Copy link
Contributor

@JPinkney JPinkney commented Nov 9, 2020

Signed-off-by: Josh Pinkney joshpinkney@gmail.com

What does this PR do?

This PR is the server side part to redhat-developer/vscode-yaml#388

What issues does this PR fix or reference?

redhat-developer/vscode-yaml#387

Is it tested? How?

Follow test instructions in: redhat-developer/vscode-yaml#388

@coveralls
Copy link

coveralls commented Nov 9, 2020

Coverage Status

Coverage increased (+0.1%) to 78.055% when pulling 6024f9a on schemaAssociations into 5862fe5 on master.

Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
Copy link
Collaborator

@evidolob evidolob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JPinkney JPinkney merged commit 5c483ee into master Nov 10, 2020
@JPinkney JPinkney deleted the schemaAssociations branch November 10, 2020 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants