Feat: Add config parameter to disable additional properties #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-spacek
requested review from
evidolob,
joshuawilson and
JPinkney
as code owners
|
@p-spacek Could you provide PR for vscode-yaml with adding settings for |
|
Created PR in vscode-yaml repo
|
evidolob
approved these changes
May 11, 2021
JPinkney
approved these changes
May 11, 2021
joshuawilson
approved these changes
May 11, 2021
|
@p-spacek This PR has conflict, could you resolve it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add
disableAdditionalPropertiesinto yaml configuration and if is set to true yaml validation won’t allow extra props that are not in schema (where type == 'object').By default we can achieve same behave with setting each of schema object by property
additionalProperties = false.But this global
disableAdditionalParametersset this globally for all object schemas.For my purpose I'm using this to quickly switch between strict validation mode and not-strict.
What issues does this PR fix or reference?
no ref
Is it tested? How?
added tests