Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initialise 'customTags' parameter with default value #495

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

evidolob
Copy link
Collaborator

What does this PR do?

It fixes error:

Error - 2:38:37 pm] (node:5928) UnhandledPromiseRejectionWarning: TypeError: customTags.filter is not a function 
at Object.filterInvalidCustomTags (c:\Users\_username_\.vscode\extensions\redhat.vscode-yaml-0.20.0\node_modules\yaml-language-server\out\server\src\languageservice\utils\arrUtils.js:56:23)
at Object.customTagsToAdditionalOptions (c:\Users\_username_\.vscode\extensions\redhat.vscode-yaml-0.20.0\node_modules\yaml-language-server\out\server\src\languageservice\utils\parseUtils.js:51:37) 
at Object.parse (c:\Users\_username_\.vscode\extensions\redhat.vscode-yaml-0.20.0\node_modules\yaml-language-server\out\server\src\languageservice\parser\yamlParser07.js:79:44) 
at YamlDocuments.ensureCache (c:\Users\_username_\.vscode\extensions\redhat.vscode-yaml-0.20.0\node_modules\yaml-language-server\out\server\src\languageservice\parser\yaml-documents.js:44:40)
at YamlDocuments.getYamlDocument (c:\Users\_username_\.vscode\extensions\redhat.vscode-yaml-0.20.0\node_modules\yaml-language-server\

Find by telemetry

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
@coveralls
Copy link

coveralls commented Jun 22, 2021

Coverage Status

Coverage increased (+0.005%) to 78.473% when pulling 8cf6bb3 on evidolob:fix-customtag-filter into 9008ead on redhat-developer:main.

@evidolob evidolob merged commit 9e6ed73 into redhat-developer:main Jun 23, 2021
@evidolob evidolob deleted the fix-customtag-filter branch June 23, 2021 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants