Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support relative path in inline schema comment #499

Merged
merged 2 commits into from
Jun 30, 2021
Merged

Support relative path in inline schema comment #499

merged 2 commits into from
Jun 30, 2021

Conversation

evidolob
Copy link
Collaborator

What does this PR do?

Add support for relative and absolute path in inline schema comment:

# yaml-language-server: $schema=../relative/path/to/schema

What issues does this PR fix or reference?

Resolve: #371

Is it tested? How?

With tests

@evidolob
redhat-developer#371 Support relative path in inline schema comment
93331d0 
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
@evidolob evidolob self-assigned this Jun 29, 2021
@coveralls
Copy link

coveralls commented Jun 29, 2021 •
edited

Coverage Status

Coverage increased (+0.05%) to 78.523% when pulling fbe6677 on evidolob:resolve-relative-path into 9e6ed73 on redhat-developer:main.

@evidolob evidolob merged commit 8b50f5c into redhat-developer:main Jun 30, 2021
@evidolob evidolob deleted the resolve-relative-path branch June 30, 2021 11:08
@JPinkney JPinkney mentioned this pull request Jul 8, 2021
Closed
4 tasks
@evidolob evidolob mentioned this pull request Jul 15, 2021
Closed
4 tasks
@hurou927 hurou927 mentioned this pull request Sep 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JPinkney JPinkney JPinkney approved these changes

@joshuawilson joshuawilson Awaiting requested review from joshuawilson

Assignees

@evidolob evidolob

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Relative path in inline schema
3 participants
@evidolob @coveralls @JPinkney