Fix fetching nested http settings #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robb-j Could you fix build? |
|
That's fixed, it was a code formatting issue in the test. |
evidolob
approved these changes
Jul 19, 2021
JPinkney
approved these changes
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR tweaks the way the
httpconfiguration section is pulled from the client. It pulls the entirehttpsection at once then plucks out the values it needs. I do assume there is no sensitive client information other thatproxyandproxyStrictSSLon thehttpsection which shouldn't be pulled.In my research I've found no solid definition for what a
sectionin the LSP is so my thinking is that usage of it should be as simple as possible for most clients to support it.What issues does this PR fix or reference?
Nova doesn't currently have a way to configure how workspace settings are passed to the server and it does it in a bit of an odd way at the moment, which I've described in the issue below. Requesting
http.proxyin Nova returns{}which was getting passed straight torequests_lightand breaking it.Is it tested? How?
With unit tests. I updated the existing unit test to follow the new LSP message structure and added an assertion for the shape of settings passed to
setConfiguration.I ran the modified server in Nova using
npm linkand confirmed that schemas were being loaded and tooltips were showing again.I can try running it with VSCode if you like but I don't currently have an extension development setup for it.