Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not send 'null' in to telemetry #513

Merged
merged 1 commit into from
Jul 20, 2021
Merged

Do not send 'null' in to telemetry #513

merged 1 commit into from
Jul 20, 2021

Conversation

evidolob
Copy link
Collaborator

What does this PR do?

Redirect null error to console.log instead of console.error.
To not track that null message in telemetry.

That null message appears from vscode-nls library, which in some cases cannot load configuration file.

@evidolob
Do not send 'null' in to telemetry
ebed8ac 
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
@coveralls
Copy link

coveralls commented Jul 19, 2021 •
edited

Coverage Status

Coverage remained the same at 78.155% when pulling ebed8ac on evidolob:fix-null-in-telemetry into e44fc1b on redhat-developer:main.

@evidolob evidolob merged commit 892da83 into redhat-developer:main Jul 20, 2021
@evidolob evidolob deleted the fix-null-in-telemetry branch July 20, 2021 06:41
remcohaszing pushed a commit to remcohaszing/yaml-language-server that referenced this pull request Aug 22, 2021
@evidolob
Fix opening local schema on windows (redhat-developer#479)
17f98cf 
* redhat-developer#513 fix opening local schema on windows

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

* fix test

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

* Fix opening local schema file on windows

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

* fix test

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

* fix test

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JPinkney JPinkney JPinkney approved these changes

@joshuawilson joshuawilson Awaiting requested review from joshuawilson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@evidolob @coveralls @JPinkney