Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix document symbols, when key is not string #594

Merged
merged 2 commits into from
Nov 23, 2021

Conversation

evidolob
Copy link
Collaborator

What does this PR do?

Fix yaml.hierarchicalDocumentSymbols.error error message on telemetry.
That can be caused when mapping key is not string.

What issues does this PR fix or reference?

none

Is it tested? How?

with tests.

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
@coveralls
Copy link

coveralls commented Nov 22, 2021

Coverage Status

Coverage increased (+0.04%) to 78.224% when pulling a47905f on evidolob:fix-document-symbols into d670e30 on redhat-developer:main.

src/languageservice/services/documentSymbols.ts Outdated Show resolved Hide resolved
src/languageservice/services/documentSymbols.ts Outdated Show resolved Hide resolved
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
@evidolob evidolob requested a review from gorkem November 23, 2021 08:24
@evidolob evidolob merged commit 4e6e194 into redhat-developer:main Nov 23, 2021
@evidolob evidolob deleted the fix-document-symbols branch November 23, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants