feat: disable default props #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gorkem
suggested changes
Dec 14, 2021
| properties: { | ||
| scripts: { | ||
| type: 'object', | ||
| properties: { |
There was a problem hiding this comment.
Can we possibly have a second non-string property added to this test case?
There was a problem hiding this comment.
I'm sorry for the longer delay...
I modified the UT. Have a look if I understood correctly your note, please.
vscode-yaml PR is here redhat-developer/vscode-yaml#667
| properties: { | ||
| scripts: { | ||
| type: 'object', | ||
| properties: { |
There was a problem hiding this comment.
Can we have a non-string property added?
gorkem
approved these changes
Dec 22, 2021
evidolob
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add config to exclude not required default props from completion.
fix: required prop with default value or with const
The reason why users appreciated this feature is that users don't have to specify default properties. Only if the default value needs to be changed, it makes sense to add them (but not all of them automatically).
What issues does this PR fix or reference?
no ref
Is it tested? How?
add unit tests