fix/suggestion item title #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-spacek
commented
Feb 11, 2022
| @@ -81,7 +81,8 @@ | |||
| "build:libs": "yarn compile:umd && yarn compile:esm", | |||
| "compile:umd": "tsc -p ./tsconfig.umd.json", | |||
| "compile:esm": "tsc -p ./tsconfig.esm.json", | |||
| "check-dependencies": "node ./scripts/check-dependencies.js" | |||
| "check-dependencies": "node ./scripts/check-dependencies.js", | |||
| "pull-remote": "git pull https://github.com/redhat-developer/yaml-language-server.git main" | |||
There was a problem hiding this comment.
this change shouldn't be there.
I can remove this if you don't want this in scrips...
but this command is useful to merge changes from your repo into forked one...
There was a problem hiding this comment.
I don’t think that we will use that script, but I'm OK to keep it
There was a problem hiding this comment.
It is better to remove. It will confuse me :)
evidolob
approved these changes
Feb 14, 2022
msivasubramaniaan
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fix logic of the
schema.title.I had a problem, that the previous
titlecould be modified by title from parents. Soschema.titlecould contain a title from its parent. And then I wasn't able to return the correct name of a suggestion item (display of the real title, name of the ref object, parent title).So this PR adds a new
closestTitleprop, that should cover previous functionality.I went through all
schema.titleand tried to decide where to usetitleorclosesTitle. Results of the UT are ok, but I will be better to check this from your side.What issues does this PR fix or reference?
no ref
Is it tested? How?
Modified one UT that covers this change