Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed auto completion not suggest const for array #670

Conversation

msivasubramaniaan
Copy link
Contributor

What does this PR do?

Auto completion should not suggest const value from schema for Array

What issues does this PR fix or reference?

#620

Is it tested? How?

Yes. with UT

@coveralls
Copy link

coveralls commented Mar 2, 2022

Coverage Status

Coverage increased (+0.04%) to 81.433% when pulling ba09954 on msivasubramaniaan:fix-autoCompletion-array-should-not-suggest-const into 99fd9f0 on redhat-developer:main.

src/languageservice/services/yamlCompletion.ts Outdated Show resolved Hide resolved
src/languageservice/services/yamlCompletion.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@evidolob evidolob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@evidolob evidolob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@gorkem gorkem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@msivasubramaniaan msivasubramaniaan merged commit 7a2cb7e into redhat-developer:main Mar 13, 2022
@msivasubramaniaan msivasubramaniaan deleted the fix-autoCompletion-array-should-not-suggest-const branch June 10, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants