Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: merge simple property completion #685

Conversation

p-spacek
Copy link
Contributor

What does this PR do?

try to merge simple property completion from anyOf objects.
It's used syntax for choice in snippets: ${1|one,two,three|} https://code.visualstudio.com/docs/editor/userdefinedsnippets#_choice

original:

Screen.Recording.2022-03-22.at.13.37.14.mov

after this PR:

Screen.Recording.2022-03-22.at.13.13.26.mov

schema

{
  "anyOf": [
    {
      "properties": {
        "prop": {
          "const": "const value"
        }
      }
    },
    {
      "properties": {
        "prop": {
          "const": "const value2"
        }
      }
    },
    {
      "properties": {
        "prop": {
          "type": "boolean",
          "default": false
        }
      }
    },
    {
      "properties": {
        "prop": {
          "type": "null"
        }
      }
    }
  ]
}

What issues does this PR fix or reference?

no ref

Is it tested? How?

modified existing and add new

@coveralls
Copy link

coveralls commented Mar 22, 2022

Coverage Status

Coverage increased (+0.3%) to 81.849% when pulling e7205fd on p-spacek:fix/merge-simple-property-completion into 01d4e9e on redhat-developer:main.

@msivasubramaniaan msivasubramaniaan merged commit 078976c into redhat-developer:main Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants