feat: add diagnostic data with missing properties #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you also planning to contribute |
I didn't plan it (I needed some customized functionality in client, so I didn't need it in YLS), but I can add it (but not sure when). |
gorkem
approved these changes
Oct 14, 2022
msivasubramaniaan
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When problem
'Property {0} is not allowed.'is found during diagnostic it will extenddiagnostic.databy possible props that could be inside the object.diagnostic.data = Object.keys(schema.properties) subtract seenPropertiesthen it can be used inside
CodeActionto suggest proper properties instead of the wrong one.What issues does this PR fix or reference?
no ref
Is it tested? How?
added tests