feat(modeline): Modeline takes precendence over registerContributor API #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: - Right now, when a file is watched by the registerContributor API a user has no way of overriding that schema. In certain cases, a user may want to override the schema provided by the registerContributor API on a file by file basis. Solution: - Make the modeline become a higher priority then the registerContributor API. That way users have the ability to always override the schema for the given file.
|
Any documentation/readme updates needed? |
|
For context, this is affecting aws/serverless-application-model#2645 |
|
Hey, welcome back @jpinkney-aws :) The suggested priority order makes sense. I will review it ASAP but can you also add a note to the README that modeline will override the extensions? |
gorkem
approved these changes
Dec 17, 2022
|
@msivasubramaniaan Can you complete the review for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Problem:
Solution:
What issues does this PR fix or reference?
aws/aws-toolkit-vscode#3012
Is it tested? How?