fix: completion value with dash #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-spacek
force-pushed
the
fix/completion-item-value-with-dash
branch
from
4fd5bd9
to
8aa95d1
Compare
|
@p-spacek Can you please update the base branch? |
p-spacek
force-pushed
the
fix/completion-item-value-with-dash
branch
from
8aa95d1
to
4bcf688
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fix the completion item range when yaml contains a word ending with a dash symbol.
Screen.Recording.2023-01-17.at.11.03.10.mov
I removed the piece of code that caused this problem (all existing tests passed after removing it).
To be honest I am not sure why this code was there. I tried to think about but I wasn't able to find a scenario when is needed to subtract one character if the current position contains
-note that this example didn't use removed piece of code
array: -What issues does this PR fix or reference?
no ref
Is it tested? How?
added test