-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace multiple space into single space on markdown text in hover #844
Merged
msivasubramaniaan
merged 7 commits into
main
from
886-yaml-underscore-being-escaped-in-description-attribute-when-hovering-over-an-attribute
Feb 27, 2023
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
19c35bc
replace multiple space into single space on markdown text in hover
msivasubramaniaan f1a088a
removed escape sequece when string has more number of indentation
msivasubramaniaan 091f343
Merge branch 'main' into 886-yaml-underscore-being-escaped-in-descrip…
msivasubramaniaan 22b36a1
updated test case
msivasubramaniaan 7248798
Merge branch 'main' into 886-yaml-underscore-being-escaped-in-descrip…
msivasubramaniaan 61b68f0
Merge branch 'main' into 886-yaml-underscore-being-escaped-in-descrip…
msivasubramaniaan d0f43fc
replace space with indetation
msivasubramaniaan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,7 +5,7 @@ | |
*--------------------------------------------------------------------------------------------*/ | ||
'use strict'; | ||
|
||
import { Hover, MarkupContent, Position, Range } from 'vscode-languageserver-types'; | ||
import { Hover, MarkupContent, MarkupKind, Position, Range } from 'vscode-languageserver-types'; | ||
import { matchOffsetToDocument } from '../utils/arrUtils'; | ||
import { LanguageSettings } from '../yamlLanguageService'; | ||
import { YAMLSchemaService } from './yamlSchemaService'; | ||
|
@@ -23,6 +23,7 @@ import { ASTNode } from 'vscode-json-languageservice'; | |
|
||
export class YAMLHover { | ||
private shouldHover: boolean; | ||
private indentation: string; | ||
private schemaService: YAMLSchemaService; | ||
|
||
constructor(schemaService: YAMLSchemaService, private readonly telemetry: Telemetry) { | ||
|
@@ -33,6 +34,7 @@ export class YAMLHover { | |
configure(languageSettings: LanguageSettings): void { | ||
if (languageSettings) { | ||
this.shouldHover = languageSettings.hover; | ||
this.indentation = languageSettings.indentation; | ||
} | ||
} | ||
|
||
|
@@ -86,9 +88,10 @@ export class YAMLHover { | |
); | ||
|
||
const createHover = (contents: string): Hover => { | ||
const regex = new RegExp(this.indentation, 'g'); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
const markupContent: MarkupContent = { | ||
kind: 'markdown', | ||
value: contents, | ||
kind: MarkupKind.Markdown, | ||
value: contents.replace(regex, ' '), | ||
}; | ||
const result: Hover = { | ||
contents: markupContent, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added pre launch check