Fix anchor diagnostics #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraftwerk28
force-pushed
the
fix/array-unused-anchor
branch
from
86a793b
to
f023399
Compare
kraftwerk28
force-pushed
the
fix/array-unused-anchor
branch
from
f023399
to
862d081
Compare
gorkem
suggested changes
Feb 25, 2023
test/schemaValidation.test.ts
Outdated
| @@ -1966,5 +1966,17 @@ obj: | |||
| expect(result[0].message).to.eq('Matches multiple schemas when only one must validate.'); | |||
| expect(telemetry.messages).to.be.empty; | |||
| }); | |||
|
|
|||
| it('Unused anchors in an array', async () => { | |||
There was a problem hiding this comment.
This test should be in
There was a problem hiding this comment.
Sure, I've updated an existing test case to have multiple [un]used anchors handling in an array.
kraftwerk28
force-pushed
the
fix/array-unused-anchor
branch
from
862d081
to
1538011
Compare
|
@msivasubramaniaan Can you review and merge this one if it is all right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes broken warnings on unused anchors inside an array:
What issues does this PR fix or reference?
Is it tested? How?
Test case included in PR.