Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: snippets in additionalProperties #951

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

p-spacek
Copy link
Contributor

What does this PR do?

fixes issue where additionalProperties were ignored on value completion if the object schema contains properties

check the test and code fix, it's more descriptive probabbly

What issues does this PR fix or reference?

extends on of the previous fix #717

Is it tested? How?

adds test

@coveralls
Copy link

Coverage Status

coverage: 84.076%. remained the same
when pulling 95229f2 on jigx-com:fix/snippets-in-aditionalProperties
into dfccc6f on redhat-developer:main.

Copy link
Collaborator

@gorkem gorkem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants