Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue119 Concept-module rules are too strict #150

Merged
merged 6 commits into from Aug 4, 2021
Merged

Issue119 Concept-module rules are too strict #150

merged 6 commits into from Aug 4, 2021

Conversation

emmurphy1
Copy link
Collaborator

See Issue 119 for the discussion.

@yzimmerm
Copy link

= Latency improvement by minimizing memory swapping

[role="_abstract"]
Swapping pages to disk can introduce latency in any environment. To ensure low latency, ensure that you have enough memory in your systems, so that swapping is not necessary. Always size the physical RAM as appropriate for your application and system.

Use the [command]vmstat command to monitor memory usage and watch the [parameter]si (swap in) and [parameter]so (swap out) fields. It is optimal that they remain zero as much as possible.

[literal,subs="+quotes,verbatim"]

$ vmstat
procs -----------memory---------- ---swap--- -----io---- --system-- ------cpu-----
r b swpd free buff cache si so bi bo in cs us sy id wa st
9 0 4186588 517872 28 4366932 0 1 4 207 0 1 9 3 88 0 0

@@ -29,7 +29,7 @@ The concept body describes the subject of the concept module.
Apart from paragraphs, you can use other AsciiDoc elements, such as lists, tables, or examples.
Consider including graphics or diagrams to speed up the understanding of the concept.

Do not include any instructions to perform an action, such as executing a command.
Avoid including instructions to perform an action, such as executing a command.
Action items belong in procedure modules.
See also link:http://www.informationmapping.com/fspro2013-tutorial/infotypes/infotype2.html[The Six Information Types] at _informationmapping.com_ for ways to present different types of conceptual information: principle, concept, structure, process, fact.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wording addition per meeting. Just a start. Feel free to tweak as needed.

... procedure modules. However, in some cases a concept or reference can include suggested actions when those actions are simple, are highly dependent on the context of the module, and have no place in any procedure module. In such cases, ensure that the heading of the concept or reference remains a noun phrase and not a gerund.

For example, see the following section for link:https://access.redhat.com/documentation/en-us/red_hat_process_automation_manager/7.9/html-single/developing_decision_services_in_red_hat_process_automation_manager/index#bound_variables_in_patterns_and_constraints[Bound variables in patterns and constraints] and other sections that follow it in the example document. These concept and reference modules contain actions that are not suitable for standalone procedure modules but are relevant actions to understand in the context of the concept or reference being described.

@@ -31,7 +31,7 @@ The contents of a concept module give the user descriptions and explanations nee

* Look at nouns and noun phrases in related procedure modules and assemblies to find the concepts to explain to users.
* Explain only things that are visible to users. Even if a concept is interesting, it probably does not require explanation if it is not visible to users.
* Do not include any instructions to perform an action, such as executing a command. Action items belong in procedure modules.
* Avoid including instructions to perform an action, such as executing a command. Action items belong in procedure modules.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how much of the above actual doc instruction to duplicate here in the template. Maybe the same instruction from above but exclude the example? Trying to be consistent and clear while not burdening the template too much.

Copy link
Member

@ncbaratta ncbaratta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Do not include any instructions to perform an action, such as executing a command.
Action items belong in procedure modules.
Avoid including action items. Action items belong in procedure modules. However, in some cases a concept or reference module can include suggested actions when those actions are simple, are highly dependent on the context of the module, and have no place in any procedure module. In such cases, ensure that the heading of the concept or reference remains a noun phrase and not a gerund. For example, see link:https://access.redhat.com/documentation/en-us/red_hat_process_automation_manager/7.9/html-single/developing_decision_services_in_red_hat_process_automation_manager/index#bound_variables_in_patterns_and_constraints[
"Bound variables in patterns and constraints"] and the sections that follow it. These concept and reference modules contain actions that are not suitable for standalone procedure modules but are relevant actions to understand in the context of the concept or reference being described.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Bound variables in patterns and constraints"] and the sections that follow it. These concept and reference modules contain actions that are not suitable for standalone procedure modules but are relevant actions to understand in the context of the concept or reference being described.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rkratky can you explain why you don't want to include the examples?This is for the guide and not the template. I think the examples are very useful. The concept is somewhat abstract and I am afraid that writers will misinterpret this exception and use if for more explicit action.

emmurphy1 and others added 3 commits May 3, 2021 14:11
@emmurphy1 emmurphy1 changed the title WIP: Issue119 Concept-module rules are too strict Issue119 Concept-module rules are too strict Aug 4, 2021
@emmurphy1 emmurphy1 merged commit 0a859e3 into master Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants