cleanup action test #16
Conversation
|
Our Model Predicts this PR to be in category [6] |
Co-authored-by: Michael Clifford <mcliffor@redhat.com>
|
Can you also update |
|
Our Model Predicts this PR to be in category [6] |
| name: Time To Merge Tool - Model Inference Test | ||
| description: 'This is the github action to predict time to merge for a new pull request' | ||
| author: 'redhat-et' | ||
|
|
||
| inputs: |
There was a problem hiding this comment.
I'm not 100% sure how we handle the env variables, but I don't think we need them in this file and the inference action yaml.
There was a problem hiding this comment.
Looking at a few existing action.yml files I see most of them are inputting these env variables in this file itself. https://github.com/actions/stale/blob/main/action.yml
However, if you suggest we can keep them in the inference.yaml only and move them to action later?
There was a problem hiding this comment.
no no. let's leave them in both places for now. But I think eventually we will be able to move them out of the inference.yaml
There was a problem hiding this comment.
Yeah, I agree with this. 👍
action.yml
Outdated
| outputs: | ||
| prediction: | ||
| description: 'Provides a prediction of the PRs time to merge' | ||
|
|
||
| runs: | ||
| using: 'docker' | ||
| image: 'Containerfile' |
There was a problem hiding this comment.
I think we need to change the file name from Containerfile to Dockerfile and change the image: tag here to Dockerfile as well.
|
/LGTM |
Quick cleanup for action files.