Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added default namespace to ovf Envelope #422

Closed
wants to merge 1 commit into from
Closed

Added default namespace to ovf Envelope #422

wants to merge 1 commit into from

Conversation

breillyr
Copy link
Contributor

@breillyr breillyr commented Mar 8, 2019 •
edited

Child nodes should inherit ovf namespace - https://bugzilla.redhat.com/show_bug.cgi?id=1622075

@breillyr breillyr changed the title Removed ovf namespace from root element Envelope Added default namespace to ovf Envelope Mar 8, 2019
@breillyr breillyr mentioned this pull request Mar 8, 2019
Open
@sandrobonazzola
Copy link

@yuvalturg can you help verifying this fix?

@ghost
Copy link

ghost commented Mar 22, 2019

tested with
engine: Software Version:4.3.1.1-1.el7
Host: oVirt Node 4.3.1
results:
2019-03-22 08:07:54,748-04 ERROR [org.ovirt.engine.core.utils.ovf.OvfManager] (default task-10) [5ed6c6bd-ec7e-4ee5-b973-12d614383d5d] Error parsing OVF due to OVF error: [Empty Name]: cannot read '//*/DiskSection' with value: null
engine.log
engine.log

full log at:
https://drive.google.com/open?id=1LmNnTrLEXJr6Sm-d5J8OBp_Zz7nmn9I-

@ghost
Copy link

ghost commented Apr 2, 2019

@breillyr have you seen my the output produced?

@breillyr
Copy link
Contributor Author

@NirLevyRH I've made a small change, could you test?

@ghost
Copy link

ghost commented Aug 12, 2019

@breillyr
here is my tested proposal for resolving the issue.
https://github.com/NirLevyRH/imagefactory/commit/d0cf6f0f63e21c7fa7f4094eac884d7f67c65056

@breillyr
Copy link
Contributor Author

Closing as this is a dupe of #429
Thanks for the patch @NirLevyRH

@breillyr breillyr closed this Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@breillyr @sandrobonazzola