Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operators [R] cert-manager (1.4.0 1.4.1 1.4.2 1.4.3 1.4.4 1.5.3 1.5.4 1.6.0 1.6.1) #434

Merged

Conversation

yselkowitz
Copy link
Contributor

@yselkowitz yselkowitz commented Nov 12, 2021

This causes the operator to be displayed in OperatorHub in the web console on architectures other than x86_64.

Please let me know if there is a different way to add these; I didn't see a CSV upstream.

/cc @wallrj

Updates to existing Operators

  • Did you create a ci.yaml file according to the update instructions?
  • Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
  • Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
  • Have you tested an update to your Operator when deployed via OLM?
  • Is your submission signed?

Your submission should not

  • Modify more than one operator
  • Modify an Operator you don't own
  • Rename an operator - please remove and add with a different name instead
  • Modify any files outside the above mentioned folders
  • Contain more than one commit. Please squash your commits.

@openshift-ci
Copy link

openshift-ci bot commented Nov 12, 2021

@yselkowitz: GitHub didn't allow me to request PR reviews from the following users: wallrj.

Note that only redhat-openshift-ecosystem members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

This causes the operator to be displayed in OperatorHub in the web console on architectures other than x86_64.

Please let me know if there is a different way to add these; I didn't see a CSV upstream.

/cc @wallrj

Updates to existing Operators

  • Did you create a ci.yaml file according to the update instructions?
  • Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
  • Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
  • Have you tested an update to your Operator when deployed via OLM?
  • Is your submission signed?

Your submission should not

  • Modify more than one operator
  • Modify an Operator you don't own
  • Rename an operator - please remove and add with a different name instead
  • Modify any files outside the above mentioned folders
  • Contain more than one commit. Please squash your commits.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Nov 12, 2021

Hi @yselkowitz. Thanks for your PR.

I'm waiting for a redhat-openshift-ecosystem member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. openshift-operator labels Nov 12, 2021
@github-actions
Copy link
Contributor

@jakexks,@wallrj , please approve as you are original reviewer(s).

  • To add more contributors to ci.yaml follow instruction here.
  • To approve follow instruction here

@github-actions github-actions bot changed the title cert-manager: add arch labels operators [R] cert-manager (1.4.0 1.4.1 1.4.2 1.4.3 1.4.4 1.5.3 1.5.4 1.6.0 1.6.1) Nov 12, 2021
@github-actions github-actions bot added allow/operator-recreate ok-to-test Indicates a non-member PR verified by an org member that is safe to test. dco-failed and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 12, 2021
@framework-automation
Copy link
Collaborator

/merge possible

@github-actions
Copy link
Contributor

DCO is missing. Please signoff your commits !!!

This causes the operator to be displayed in OperatorHub in the web
console on architectures other than x86_64.

Signed-off-by: Yaakov Selkowitz <yselkowi@redhat.com>
@framework-automation
Copy link
Collaborator

/merge possible

@yselkowitz
Copy link
Contributor Author

/retest

@framework-automation
Copy link
Collaborator

/merge possible

@github-actions
Copy link
Contributor

Current PR can be merged automatically, but there is missing authorized-changes label. One can find out more info here.

@framework-automation
Copy link
Collaborator

/merge possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants