Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operators [CI] syndesis (1.11.0) #89

Conversation

phantomjinx
Copy link
Contributor

Signed-off-by: phantomjinx p.g.richardson@phantomjinx.co.uk

Thanks submitting your Operator. Please check below list before you create your Pull Request.

New Submissions

Updates to existing Operators

  • Did you create a ci.yaml file according to the update instructions?
  • Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
  • Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
  • Have you tested an update to your Operator when deployed via OLM?
  • Is your submission signed?

Your submission should not

  • Modify more than one operator
  • Modify an Operator you don't own
  • Rename an operator - please remove and add with a different name instead
  • Modify any files outside the above mentioned folders
  • Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

  1. Description about the managed Application and where to find more information
  2. Features and capabilities of your Operator and how to use it
  3. Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

  • Human readable name and 1-liner description about your Operator
  • Valid category name1
  • One of the pre-defined capability levels2
  • Links to the maintainer, source code and documentation
  • Example templates for all Custom Resource Definitions intended to be used
  • A quadratic logo

Remember that you can preview your CSV here.

--

1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need

2 For more information see here

Signed-off-by: phantomjinx <p.g.richardson@phantomjinx.co.uk>
@openshift-ci
Copy link

openshift-ci bot commented Aug 6, 2021

Hi @phantomjinx. Thanks for your PR.

I'm waiting for a redhat-openshift-ecosystem member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 6, 2021
@openshift-ci openshift-ci bot requested review from J0zi and mvalarh August 6, 2021 16:42
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2021

Dockerfile or bundle.Dockerfile is added/changed. Note that for security reasons none of these files are going to be used when building bundle. Docker file will be generated and all label information is taken from annotations.yaml.

@github-actions github-actions bot changed the title chore(release): syndesis-operator (1.11.0) operators [CI] syndesis (1.11.0) Aug 6, 2021
@github-actions github-actions bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 6, 2021
@phantomjinx
Copy link
Contributor Author

Hi @J0zi, @mvalarh,

Can you give steerage on this please?

I am bringing Syndesis over from upstream-community to here since its openshift-only (posted in the wrong catalog). So 1.9.0 is old now but I wanted to maintain some kind of upgrade graph to 1.11.0 and then add 1.12.0. However, 1.9.0 is using metadata format but we changed over to bundle format in 1.11.0 so tests are failing. How should this be handled, please? Do I need to convert 1.9.0 and 1.7.0 to bundle format first?

Thx.

@J0zi
Copy link
Contributor

J0zi commented Aug 10, 2021

@phantomjinx, please do not mix formats. The newest version is in bundle format, other versions are in package manifest format.

@phantomjinx
Copy link
Contributor Author

@phantomjinx, please do not mix formats. The newest version is in bundle format, other versions are in package manifest format.

So that's the question....

Given we've moved over to the bundle format, should I delete the old versions or update them 1 at a time to bundle format?

@mvalarh
Copy link
Contributor

mvalarh commented Aug 11, 2021

/test all

@mvalarh
Copy link
Contributor

mvalarh commented Aug 11, 2021

@phantomjinx We are supporting only one format for all operators. If you want to upgrade to bundle. Please do it for all versions and remove syndesis.package.yaml file.

You can convert all versions to bundle in current PR

@openshift-ci
Copy link

openshift-ci bot commented Aug 11, 2021

@phantomjinx: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/4.6-deploy-operator-on-openshift 4e712c8 link /test 4.6-deploy-operator-on-openshift
ci/prow/4.7-deploy-operator-on-openshift 4e712c8 link /test 4.7-deploy-operator-on-openshift
ci/prow/4.8-deploy-operator-on-openshift 4e712c8 link /test 4.8-deploy-operator-on-openshift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mvalarh
Copy link
Contributor

mvalarh commented Aug 13, 2021

@phantomjinx can you please resolve conflicts?

@openshift-ci
Copy link

openshift-ci bot commented Aug 15, 2021

@phantomjinx: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 15, 2021
@phantomjinx
Copy link
Contributor Author

Superceded by 1.12.0

@phantomjinx phantomjinx closed this Sep 9, 2021
rooftopcellist pushed a commit to rooftopcellist/community-operators-prod that referenced this pull request Nov 1, 2022
Signed-off-by: Idan Moyal <idan.moyal@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. openshift-operator openshift-started-4.6 openshift-started-4.7 openshift-started-4.8
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants