reordering submit flow to create test results as first action #1151
Conversation
openshift-ci
bot
added
the
approved
|
from change #1151: |
|
/test 4.12-e2e |
internal/pyxis/submit.go
Outdated
| // Create the test results, so we can fail fast if version check throws error. | ||
| testResults := certInput.TestResults | ||
| testResults, err = p.createOrUpdateTestResults(ctx, testResults, http.MethodPost) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("could not create test results: %v", err) | ||
| } | ||
|
|
There was a problem hiding this comment.
I understand this is here to fail fast, but it would seem that if there are other failures (e.g. if certImage.Repositories == 0 a few lines down), wouldn't we have created a TestResult for this account before we've asserted whether their content is valid?
There was a problem hiding this comment.
Good catch, that should probably be first, since it was lost in the comments, I'll move it to be first thing.
acornett21
force-pushed
the
fix_submission_order
branch
from
e85ac24
to
f4459c3
Compare
|
from change #1151: |
acornett21
force-pushed
the
fix_submission_order
branch
from
f4459c3
to
b6eedb7
Compare
|
from change #1151: |
…inking to an imageID later in the flow to be able to fail fast and and not have incomplete results attached to an image Signed-off-by: Adam D. Cornett <adc@redhat.com>
acornett21
force-pushed
the
fix_submission_order
branch
from
b6eedb7
to
7dfeeb0
Compare
|
from change #1151: |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acornett21, Allda, bcrochet, komish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
createTestResultswas modified to account for bothPATCH/POST, since there would be less duplicate code, if others are happier with two distinct methods, I'm happy to refactor that way as well.