Do not write artifacts to current dir in tests #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
komish
reviewed
Jul 29, 2022
komish
reviewed
Jul 29, 2022
komish
reviewed
Jul 29, 2022
komish
reviewed
Jul 29, 2022
komish
approved these changes
Jul 29, 2022
A lot of the tests would create artifacts folders in the directory under test. They would also create preflight.log in those same locations. This makes sure that that does not occur. It also removes the side effect from the artifacts.Path() call. That call would create the artifacts dir, and that's just very unexpected. Instead, this moves the dir creation side effect into the artifacts.WriteFile() call, which is much more an expected behaviour. Signed-off-by: Brad P. Crochet <brad@redhat.com>
bcrochet
force-pushed
the
fix-artifacts-in-tests
branch
from
91f4f54
to
d75ca0f
Compare
acornett21
approved these changes
Aug 2, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acornett21, bcrochet, komish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of the tests would create artifacts folders in the directory
under test. They would also create preflight.log in those same
locations. This makes sure that that does not occur.
It also removes the side effect from the artifacts.Path() call.
That call would create the artifacts dir, and that's just very
unexpected. Instead, this moves the dir creation side effect into
the artifacts.WriteFile() call, which is much more an expected
behaviour.
Signed-off-by: Brad P. Crochet brad@redhat.com