Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mac architectures build #942

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

mac architectures build #942

wants to merge 1 commit into from
+54 −9

Conversation

itroyano
Copy link
Contributor

@itroyano itroyano commented Apr 3, 2023

Darwin OS builds for Preflight: Intel Mac, Apple Silicon Mac.

Pending - adjust the GH Actions.

Fixes #850

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 3, 2023
@openshift-ci
Copy link

openshift-ci bot commented Apr 3, 2023

Hi @itroyano. Thanks for your PR.

I'm waiting for a redhat-openshift-ecosystem member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coveralls
Copy link

coveralls commented Apr 3, 2023 •
edited

Coverage Status

coverage: 81.752%. remained the same
when pulling 6749754 on itroyano:feature/mac-build
into d990640 on redhat-openshift-ecosystem:main.

@acornett21
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 3, 2023
@dcibot
Copy link

dcibot commented Apr 3, 2023

@acornett21 acornett21 closed this Apr 3, 2024
@acornett21 acornett21 reopened this Apr 3, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 3, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: itroyano
Once this PR has been reviewed and has the lgtm label, please assign komish for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@itroyano itroyano force-pushed the feature/mac-build branch 2 times, most recently from e6ea103 to ea14fed Compare April 3, 2024 15:29
@dcibot
Copy link

dcibot commented Apr 3, 2024

from change #942:

@itroyano itroyano marked this pull request as draft April 3, 2024 17:43
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 3, 2024
@itroyano itroyano changed the title mac architectures build (Work in Progress) mac architectures build Apr 3, 2024
@dcibot
Copy link

dcibot commented Apr 3, 2024

from change #942:

@dcibot
Copy link

dcibot commented Apr 3, 2024

from change #942:

@acornett21
Copy link
Contributor

/ok-to-test

@acornett21
Copy link
Contributor

/test 4.15-e2e

1 similar comment
@acornett21
Copy link
Contributor

/test 4.15-e2e

@acornett21
Copy link
Contributor

/test 4.15-images

@acornett21
Copy link
Contributor

/test 4.15-e2e

1 similar comment
@acornett21
Copy link
Contributor

/test 4.15-e2e

@itroyano itroyano marked this pull request as ready for review April 22, 2024 04:24
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 22, 2024
@openshift-ci openshift-ci bot requested a review from komish April 22, 2024 04:24
@acornett21
Copy link
Contributor

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skattoju skattoju Awaiting requested review from skattoju

@tonytcampbell tonytcampbell Awaiting requested review from tonytcampbell

@komish komish Awaiting requested review from komish

Assignees
No one assigned
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Preflight needs an Apple Silicon binary
4 participants
@itroyano @coveralls @acornett21 @dcibot