Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(version): remove leading v from version output #14

Merged
merged 1 commit into from
Jun 30, 2022
Merged

chore(version): remove leading v from version output #14

merged 1 commit into from
Jun 30, 2022

Conversation

bostrt
Copy link
Contributor

@bostrt bostrt commented Jun 30, 2022

The leading v will be included in tag name already.

@openshift-ci openshift-ci bot requested review from mtulio and rvanderp3 June 30, 2022 16:36
mtulio
mtulio approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@mtulio mtulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2022
@bostrt bostrt merged commit a445758 into main Jun 30, 2022
@bostrt bostrt deleted the version-fix branch June 30, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtulio mtulio mtulio approved these changes

@rvanderp3 rvanderp3 Awaiting requested review from rvanderp3

Assignees

@mtulio mtulio

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bostrt @mtulio