Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPCT-36: Supporting diagrams on the documentation #46

Merged
merged 2 commits into from
Feb 13, 2023
Merged

OPCT-36: Supporting diagrams on the documentation #46

merged 2 commits into from
Feb 13, 2023

Conversation

mtulio
Copy link
Contributor

@mtulio mtulio commented Feb 10, 2023 •
edited

@mtulio
Copy link
Contributor Author

mtulio commented Feb 10, 2023

/assign @rvanderp3

@mtulio
Copy link
Contributor Author

mtulio commented Feb 10, 2023

Screenshot from 2023-02-10 18-40-49

@mtulio
Copy link
Contributor Author

mtulio commented Feb 10, 2023

Screenshot from 2023-02-10 18-42-03

faermanj
faermanj approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@faermanj faermanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having mermaid diagrams is super cool!

@openshift-ci
Copy link

openshift-ci bot commented Feb 13, 2023

@faermanj: changing LGTM is restricted to collaborators

In response to this:

Having mermaid diagrams is super cool!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rvanderp3
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2023
@openshift-ci
Copy link

openshift-ci bot commented Feb 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: faermanj, rvanderp3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2023
@openshift-merge-robot openshift-merge-robot merged commit 93cec79 into redhat-openshift-ecosystem:main Feb 13, 2023
@mtulio mtulio deleted the docs-add-diagrams branch February 13, 2023 16:38
@mtulio mtulio added the kind/documentation Categorizes issue or PR as related to documentation. label Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faermanj faermanj faermanj approved these changes

@bostrt bostrt Awaiting requested review from bostrt

@rvanderp3 rvanderp3 Awaiting requested review from rvanderp3

Assignees

@rvanderp3 rvanderp3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mtulio @rvanderp3 @faermanj @openshift-merge-robot