Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating OWNERS file with new team member faermanj #47

Merged
merged 2 commits into from
Feb 22, 2023
Merged

Conversation

faermanj
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Feb 13, 2023
@mtulio mtulio changed the title Pls add me :) add faerman to owners file Feb 13, 2023
@mtulio mtulio changed the title add faerman to owners file added faerman to owners file Feb 13, 2023
@mtulio
Copy link
Contributor

mtulio commented Feb 14, 2023

@faermanj could you please remove bostrt from the OWNERS file too?

@rvanderp3
Copy link
Contributor

/verify-owners

@openshift-ci openshift-ci bot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Feb 14, 2023
@mtulio mtulio changed the title added faerman to owners file updating OWNERS file with new team member faermanj Feb 14, 2023
@mtulio
Copy link
Contributor

mtulio commented Feb 16, 2023

@faermanj could you please remove bostrt from the OWNERS file too?

Waiting for this change.
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 16, 2023
@faermanj
Copy link
Contributor Author

Done, thanks for the call @rvanderp3

@rvanderp3
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2023
@openshift-ci
Copy link

openshift-ci bot commented Feb 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rvanderp3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2023
@rvanderp3
Copy link
Contributor

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2023
@openshift-merge-robot openshift-merge-robot merged commit fd7b547 into redhat-openshift-ecosystem:main Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants