OPCT-177: nit rename plugins image to reflect the real name #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtulio
added
the
kind/cleanup
|
/assign @rvanderp3 @faermanj |
openshift-ci
bot
added
the
do-not-merge/hold
mtulio
removed
the
do-not-merge/hold
mtulio
changed the title
mtulio
changed the title
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rvanderp3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-robot
merged commit f3e765a
into
redhat-openshift-ecosystem:main
2 checks passed
openshift-merge-robot
pushed a commit
that referenced
this pull request
May 23, 2023
- Fix unbound variables on the CI step when creating release v0.4: https://github.com/redhat-openshift-ecosystem/provider-certification-tool/actions/runs/5047592402/jobs/9054669579 - Reorder the container build step to make sure it will succeed before creating the release, otherwise, the workflow should fail - copy and ship binaries with the prefix `opct-*` (s/openshift-provider-cert/opct/) to deprecate the cert name in future releases - update static files crashing when processing the tool with renamed argument `plugins-image` (missing on #66 ) - add dev doc expanding the release process with more information about manual tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nit pre-release to prevent future confusion when reading the code on the reference of "tools" and "plugins" images.