Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPCT-239: Fixes fetching tags to generate changelog file #78

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

mtulio
Copy link
Contributor

@mtulio mtulio commented Sep 21, 2023

Fixes #74 :

  • the CHANGELOG.md is generated by CI and available only in the rendered page. If we decide to keep it versioned, we can add it in the future. For now it is generated automatically
  • force CI step/action to fetch tags to run correctly the changelog generator
  • nits shell script

@openshift-ci
Copy link

openshift-ci bot commented Sep 21, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from mtulio. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mtulio mtulio added the kind/bug Categorizes issue or PR as related to a bug. label Sep 21, 2023
@mtulio mtulio changed the title OPCT-239: Fixing the CI step forcing to fetch tags to generate changelog file OPCT-239: Fix CI step forcing to fetch tags to generate changelog file Sep 21, 2023
@mtulio mtulio merged commit ece67cb into redhat-openshift-ecosystem:main Sep 21, 2023
5 of 6 checks passed
@mtulio mtulio deleted the fix-changelog branch September 21, 2023 22:13
@mtulio mtulio changed the title OPCT-239: Fix CI step forcing to fetch tags to generate changelog file OPCT-239: Fixes fetching tags to generate changelog file Sep 21, 2023
mtulio added a commit that referenced this pull request Sep 25, 2023
Fixes #74 :
- the CHANGELOG.md is generated by CI and available only in the rendered
page. If we decide to keep it versioned, we can add it in the future.
For now it is generated automatically
- force CI step/action to fetch tags to run correctly the changelog
generator
- nits shell script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant