Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPCT-242: Introduce command 'get images' #83

Merged
merged 5 commits into from
Oct 17, 2023

Conversation

mtulio
Copy link
Contributor

@mtulio mtulio commented Sep 27, 2023

Introduce opct get images to export all images used by OPCT (not for OCP cluster). It includes the flag --to-repository to export in the mirror format:

Default:

$ ./build/opct-linux-amd64 get images 
quay.io/ocp-cert/sonobuoy:v0.56.10
quay.io/ocp-cert/openshift-tests-provider-cert:v0.4.1
quay.io/opct/must-gather-monitoring:v0.1.0
quay.io/openshift-scale/etcd-perf:latest
registry.k8s.io/pause:3.8
  • with mirror flag --to-repository
$ ./build/opct-linux-amd64 get images --to-repository registry.example.com/validation
quay.io/ocp-cert/sonobuoy:v0.56.10 registry.example.com/validation/sonobuoy:v0.56.10
quay.io/ocp-cert/openshift-tests-provider-cert:v0.4.1 registry.example.com/validation/openshift-tests-provider-cert:v0.4.1
quay.io/opct/must-gather-monitoring:v0.1.0 registry.example.com/validation/must-gather-monitoring:v0.1.0
quay.io/openshift-scale/etcd-perf:latest registry.example.com/validation/etcd-perf:latest
registry.k8s.io/pause:3.8 registry.example.com/validation/ocp-cert:e2e-28-registry-k8s-io-pause-3-8-aP7uYsw5XCmoDy5W

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 27, 2023
@mtulio mtulio force-pushed the cmd-get-images branch 2 times, most recently from 2b87b50 to 08f68ef Compare September 27, 2023 06:43
@mtulio mtulio changed the title Introduce command 'get images' OPCT-242: Introduce command 'get images' Sep 27, 2023
@mtulio mtulio added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 27, 2023
@mtulio mtulio marked this pull request as ready for review September 27, 2023 13:37
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 27, 2023
@mtulio
Copy link
Contributor Author

mtulio commented Sep 27, 2023

/assign @rvanderp3

@mtulio
Copy link
Contributor Author

mtulio commented Sep 27, 2023

I think the documentation change will break compatibility with older versions for those reasons:

  • main branch does not have a CD release
  • documentation describing old versions will not be covered since the merged code is released. The long term solution is to versioning the documentation (planning in OPCT-251 )
  • short term solution is to split the doc changes in this PR to a buffer, or create new sections describing the changes for each OPCT release.
    /hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 27, 2023
@mtulio
Copy link
Contributor Author

mtulio commented Sep 27, 2023

I think the documentation change will break compatibility with older versions for those reasons:

  • main branch does not have a CD release
  • documentation describing old versions will not be covered since the merged code is released. The long term solution is to versioning the documentation (planning in OPCT-251 )
  • short term solution is to split the doc changes in this PR to a buffer, or create new sections describing the changes for each OPCT release.
    /hold

Problem resolved in af7dc32 by keep compatibility with older versions.

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 27, 2023
@mtulio
Copy link
Contributor Author

mtulio commented Oct 17, 2023

Hey @rvanderp3 @faermanj , please take a look?
/assign @rvanderp3 @faermanj

@rvanderp3
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rvanderp3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2023
@openshift-ci openshift-ci bot merged commit ef5e0d8 into redhat-openshift-ecosystem:main Oct 17, 2023
6 checks passed
openshift-ci bot pushed a commit to redhat-openshift-ecosystem/provider-certification-plugins that referenced this pull request Oct 17, 2023
Supporting disconnected for new collectors.

- must-gather-monitoring added in
#45
- etcdfio added in
#46
- Don't break for any collectors
- CLI change is added in the PR
redhat-openshift-ecosystem/provider-certification-tool#83
@mtulio mtulio deleted the cmd-get-images branch October 19, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants