Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPCT-257: Doc - remove machineset option in dedicated node section #89

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

mtulio
Copy link
Contributor

@mtulio mtulio commented Oct 17, 2023

Remove form the user guide the ambiguous instruction to setup dedicated node as we are requiring an agnostic installation, and providing an option to use MachineSet, but MAPI isn't available in agnostic installations/platform type None.

This option can be valid when we'll create different guides. Currently the "User Guide" is very specific for VCSP requirements. The intention of #88 is to improve it, but we don't have ETA yet.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 17, 2023
@mtulio mtulio changed the title OPCT-257: Doc - remove machineset option as MAPI is supported in Agnostic OPCT-257: Doc - remove machineset option is not valid in Agnostic Oct 17, 2023
@mtulio mtulio changed the title OPCT-257: Doc - remove machineset option is not valid in Agnostic OPCT-257: Doc - remove machineset option in dedicated node section Oct 17, 2023
@mtulio
Copy link
Contributor Author

mtulio commented Oct 17, 2023

Hey @rvanderp3 @faermanj , please take a look?
/assign @rvanderp3 @faermanj

@mtulio mtulio marked this pull request as ready for review October 17, 2023 14:35
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 17, 2023
@mtulio mtulio added the kind/documentation Categorizes issue or PR as related to documentation. label Oct 17, 2023
@rvanderp3
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rvanderp3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2023
@openshift-ci openshift-ci bot merged commit eb0fb93 into main Oct 17, 2023
6 checks passed
@mtulio mtulio deleted the opct-257-doc-setup branch October 19, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants