Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shell blocks #24

Open
halcyondude opened this issue Jul 13, 2016 · 1 comment
Open

shell blocks #24

halcyondude opened this issue Jul 13, 2016 · 1 comment

Comments

@halcyondude
Copy link
Contributor

For the many shell blocks in the build role, there is a mixture of > and | style shell blocks.

In this review: https://review.gerrithub.io/#/c/283664 Atilla recommended > instead of | for good reasons.

https://paste.fedoraproject.org/390295/46833886/

this issue is to track making the shell blocks consistent.
weshayutin pushed a commit that referenced this issue Jul 13, 2016
Improve clarity and log handling
f138d73 
A few changes that enable better logging for image building.  These
changes are the result of debugging a pile of image building jobs.

Addresses:
#4

Partially addresses (there are still a few more)
#24

* where possible in shell blocks, use args/chdir to declutter
* redirect the virt-customize phases to files in the working dir
* enable verbose and debug/trace messages from virt-customize.
* pull the builder logs from the images.  clear.  consise.  complete.
* generate a manifest of all files contained in the image
* fix a few shell blocks to use > instead of |
* create log archive w/ md5
* place logs in /var/log/artib

Change-Id: I2ad8263ce7d2693addc72ec84203a643d5f86049
@halcyondude
Copy link
Contributor Author

Many of these have been fixed, there are a few more. The ones that use shell: >, and also have a > i/o redirect seem to be problematic. will address as a back burner item at low priority unless someone wants to take a crack at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@halcyondude